Skip to content

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 6, 2025

Fixes #148488

The fix is also a change from #148556

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lqd
Copy link
Member

lqd commented Nov 6, 2025

Thanks!

r? me @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit a9795db has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned fee1-dead Nov 6, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 6, 2025
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
bors added a commit that referenced this pull request Nov 6, 2025
Rollup of 7 pull requests

Successful merges:

 - #146861 (add extend_front to VecDeque with specialization like extend)
 - #148213 (Fix invalid tag closing when leaving expansion "original code")
 - #148292 (Un-shadow object bound candidate in `NormalizesTo` goal if self_ty is trait object)
 - #148528 (run-make tests: use edition 2024)
 - #148554 (Add regression test for issue 148542)
 - #148561 (Fix ICE from async closure variance)
 - #148563 (rustdoc-search: remove broken index special case)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 76dae76 into rust-lang:master Nov 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 6, 2025
rust-timer added a commit that referenced this pull request Nov 6, 2025
Rollup merge of #148561 - chenyukang:yukang-fix-148488, r=lqd

Fix ICE from async closure variance

Fixes #148488

The fix is also a change from #148556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE Unexpected unnameable type in variance computation

5 participants